-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard navigation does not scroll with max-height and overflow: auto #221
Comments
Hi @TarekRaafat, thank you, I didn't expect a solution this quickly! Here are a few thoughts on the scrolling: It works out of the box, this is a great improvement for me 👍 A few things I noticed: The class autoComplete_selected does not seem to be set anymore, so I updated my CSS like this, which works again:
The smooth scrolling effect looks is nice, but if I press and hold the down key it is way too slow (for me it just scroll-wiggles a little up and down while the selection goes through the list), so it would be nice to have a way to disable smooth scrolling or detect that I am holding the key down and only scroll smooth if I haven't scrolled in the last few ms or something like that. Thanks again, and a nice day to you as well :) |
Very good point and I believe that your first suggestion would be more flexible because it would allow you to programmatically achieve the second behavior as well. Thanks! |
Auto-Scroll has been added to v10.0.3, but unfortunately, I had to roll back and use another method for scrolling instead of Yet, I'll keep investigating other methods until I achieve the previous For the time being, you should be good to go with the current functionality, and of course, feel free to let me know if you have any other thoughts. Have a nice day! :) |
System Information
Describe the bug
When navigating with the keyboard the scrollable resultlist does not scroll with the selection.
To Reproduce
I created a jsfiddle that demonstrates the behavior: https://jsfiddle.net/fzkyvrab/3/
Enter the search box, start typing 'f' and press down with keyboard a few times. The selected item will be out of the visible area and you have to manually scroll down to see it
Expected behavior
The search field should make it so that the active element is always visible (scrolled to it)
The text was updated successfully, but these errors were encountered: