Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a "more results" in search results #135

Closed
wants to merge 2 commits into from
Closed

Implement a "more results" in search results #135

wants to merge 2 commits into from

Conversation

varunsingh87
Copy link

This pull request implements a "more results" function, including a button, in which the developer can specify a resultsPerPage property that shows a certain number of results between every time the user clicks "More Results". It also uses other properties, including the "loadMoreResults" boolean in case the developer wants to stick to the original functionality.

Closes #95

@varunsingh87
Add 2 new properties to autoComplete class
fd5c453 
* Add resultsPerPage property -
if the developer decides to paginate the results,
he or she can set the number of results to be shown
per page
* Add loadMoreResults property -
boolean, whether to have a load more results function and button
@varunsingh87
Copy link
Author

Can a maintainer add the hacktoberfest topic to this repository as I am participating in it.

@TarekRaafat
Copy link
Owner

Hello @Borumer,

Sure, I would gladly support you.
I've already added the label for your pull request as instructed on hacktoberfest page.

What do I do if I want to contribute to a project but it doesn’t have the hacktoberfest topic?

- You can still contribute to any public GitHub repository and have it count towards your progress provided that your pull request is labeled with "hacktoberfest-accepted".

Cheers! :)

@TarekRaafat TarekRaafat added hacktoberfest-accepted DigitalOcean's Hacktoberfest enhancement New feature or request labels Oct 13, 2020
@TarekRaafat TarekRaafat marked this pull request as ready for review October 13, 2020 19:32
@TarekRaafat
Copy link
Owner

@Borumer, How would I control page navigation?

@TarekRaafat TarekRaafat added the hacktoberfest DigitalOcean's Hacktoberfest label Oct 13, 2020
@varunsingh87 varunsingh87 marked this pull request as draft October 13, 2020 23:41
@varunsingh87
Copy link
Author

varunsingh87 commented Oct 13, 2020 •
edited
Loading

@TarekRaafat Sorry, I should have clarified. I am not ready to merge, I still have a lot of work to do on this feature. Thanks for marking it, I will try to finish this by Thursday or Friday

@TarekRaafat
Copy link
Owner

@Borumer my bad, best of luck!

@varunsingh87
Copy link
Author

@TarekRaafat I need some help with this. I implemented a method called loadMoreResults in the autoComplete class, but I don't know where to get the full data list from, nor where to call it. Would you or another maintainer mind guiding me?
Thanks

@varunsingh87 varunsingh87 marked this pull request as ready for review October 17, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest DigitalOcean's Hacktoberfest hacktoberfest-accepted DigitalOcean's Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"More results"
2 participants
@varunsingh87 @TarekRaafat