Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blinking on chart labels #580

Merged
merged 2 commits into from Jul 17, 2019

Conversation

misha-erm
Copy link
Contributor

  • Fix axis labels' shaking during re-renders of same chart. This was cause by transition from 'text-anchor: middle' to 'text-anchor: end'. Extend X and Y axisLabel to have default 'text-anchor: end'

  • Fix blinking of axis labels. Axis labels didn't have any 'opacity' attrs and that's why they could blink when used together with 'floating-axis' plugin as they were moved out of g.y.axis which had opacity attr

@coveralls
Copy link

coveralls commented Jul 16, 2019

Coverage Status

Coverage increased (+0.004%) to 95.93% when pulling 536ad5e on MikeYermolayev:fix/blinks-on-chart-labels into f04d729 on TargetProcess:master.

@Mavrin Mavrin merged commit 66b4b95 into TargetProcess:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants