An attempt was made to prevent occurrence of the access violation exc…

…eption in the `PtrToString` method
Taritsyn · Oct 25, 2019 · cd0f6ea · cd0f6ea
1 parent df7df2f
commit cd0f6ea
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 10 deletions.
diff --git a/src/LibSassHost/Helpers/MarshallingHelpers.cs b/src/LibSassHost/Helpers/MarshallingHelpers.cs
@@ -121,8 +121,7 @@ public static unsafe string PtrToString(IntPtr ptr)
 			result = Encoding.UTF8.GetString(pBuffer, bufferLength);
 #else
 			var byteArrayPool = ArrayPool<byte>.Shared;
-			byte[] buffer = byteArrayPool.Rent(bufferLength + 1);
-			buffer[bufferLength] = 0;
+			byte[] buffer = byteArrayPool.Rent(bufferLength);
 
 			try
 			{

diff --git a/src/LibSassHost/LibSassHost.csproj b/src/LibSassHost/LibSassHost.csproj
@@ -33,8 +33,7 @@ This package does not contain the native implementations of LibSass. Therefore,
 		<IncludeSymbols>true</IncludeSymbols>
 		<SymbolPackageFormat>snupkg</SymbolPackageFormat>
 		<PackageTags>LibSass;Sass;SCSS;CSS</PackageTags>
-		<PackageReleaseNotes>1. Added support of the LibSass version 3.6.2;
-2. Enabled a SourceLink in NuGet package.</PackageReleaseNotes>
+		<PackageReleaseNotes>An attempt was made to prevent occurrence of the access violation exception in the `PtrToString` method.</PackageReleaseNotes>
 		<NeutralLanguage>en-US</NeutralLanguage>
 		<GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
 		<GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>

diff --git a/src/LibSassHost/readme.txt b/src/LibSassHost/readme.txt
@@ -26,8 +26,8 @@
    =============
    RELEASE NOTES
    =============
-   1. Added support of the LibSass version 3.6.2;
-   2. Enabled a SourceLink in NuGet package.
+   An attempt was made to prevent occurrence of the access violation exception in
+   the `PtrToString` method.
 
    ============
    PROJECT SITE

diff --git a/test/LibSassHost.Test.Common/LibSassHost.Test.Common.csproj b/test/LibSassHost.Test.Common/LibSassHost.Test.Common.csproj
@@ -22,10 +22,6 @@
 		<ProjectReference Include="..\..\src\LibSassHost\LibSassHost.csproj" />
 	</ItemGroup>
 
-	<ItemGroup Condition=" '$(TargetFramework)' == 'net452' Or '$(TargetFramework)' == 'net471' ">
-		<PackageReference Include="Microsoft.Extensions.PlatformAbstractions" Version="1.0.0" />
-	</ItemGroup>
-
 	<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.0' Or '$(TargetFramework)' == 'netcoreapp2.1' Or '$(TargetFramework)' == 'netcoreapp3.0' ">
 		<PackageReference Include="LibSassHost.Native.linux-x64" Version="1.2.7" />
 		<PackageReference Include="LibSassHost.Native.osx-x64" Version="1.2.7" />