Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using single-case unions as dictionary keys #161

Closed
Tarmil opened this issue Jun 16, 2023 · 1 comment
Closed

Allow using single-case unions as dictionary keys #161

Tarmil opened this issue Jun 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Tarmil
Copy link
Owner

Tarmil commented Jun 16, 2023

For all cases where we allow single-case unions as map keys, we should also allow them as dictionary keys.

Dictionaries are handled directly by System.Text.Json, but since .NET 6 we can customize its handling of keys using JsonConverter.Write/ReadAsPropertyName.
@Tarmil Tarmil added the enhancement New feature or request label Jun 16, 2023
Tarmil added a commit that referenced this issue Aug 2, 2023
@Tarmil
Merge pull request #168 from Tarmil/unions-as-dict-key
48cfa5b 
#161 Allow using single-case unions as dictionary keys
@Tarmil Tarmil mentioned this issue Aug 4, 2023
Closed
@Tarmil
Copy link
Owner Author

Tarmil commented Aug 15, 2023

Released in v1.2.

@Tarmil Tarmil closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tarmil