Write _autoenv_check_authorized_env_file to stderr #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout might be redirected, e.g. with "cd - >/dev/null", and this message should appear in stderr probably anyway. I've tried to add a test for this, by redirecting stdout in .zshenv, but cram does not handle this well (and appears to redirect stderr to stdout anyway).
| echo "" >&2 | ||
| echo "**********************************************" >&2 | ||
| echo "" >&2 | ||
| cat $1 >&2 |
There was a problem hiding this comment.
No related really, but any reason we do command ls but not command cat?
There was a problem hiding this comment.
Nope, good point.
It's likely because ls is often aliased, while cat is not.
There was a problem hiding this comment.
Yea I thought something along those lines too. Nice that you robustified this even further :)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdout might be redirected, e.g. with "cd - >/dev/null", and this
message should appear in stderr probably anyway.
I've tried to add a test for this, by redirecting stdout in .zshenv, but
cram does not handle this well (and appears to redirect stderr to stdout
anyway).