Use cksum instead of sha1sum for checksums #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
approved these changes
Jan 4, 2017
| if ! [[ -e $env_file ]]; then | ||
| echo "Missing file argument for _autoenv_hash_pair!" >&2 | ||
| return 1 | ||
| fi | ||
| env_shasum=$(sha1sum $env_file | cut -d' ' -f1) | ||
| env_cksum=${(j:.:)${:-$(cksum "$env_file")}[1,2]} |
There was a problem hiding this comment.
Adding an explicit comment explaining what (j:.:) does would be nice. zsh is so not readable...
There was a problem hiding this comment.
Fair point, added.
Should be squash-merged.
Confirmed. 👍 |
|
Thanks! |
|
Well crap. I made my own implementation earlier today and got sidetracked before I could push it. Gonna open a PR anyway since there's one difference that I think is probably important. |
rspeed
added a commit
to rspeed/contrib-zsh-autoenv
that referenced
this pull request
Jan 5, 2017
Adds a new whitelist file hashing algorithm using `cksum`, which is very fast and identical between BSD and GNU. A new parameter is added to `_autoenv_hash_pair` to specify the version, defaulting to the latest (2). It outputs a `cksum`-based hash for version 2 and `shasum`-based for version 1. Moves logic to check for an entry in `$AUTOENV_AUTH_FILE` into its own function (`_autoenv_authorized_pair`), as it may need to be called twice. Modifies `_autoenv_authorized_env_file` to check for v1 entries when v2 fails. Fixes Tarrasch#53. Alternative implementation to Tarrasch#54.
rspeed
added a commit
to rspeed/contrib-zsh-autoenv
that referenced
this pull request
Jan 10, 2017
Adds a new whitelist file hashing algorithm using `cksum`, which is very fast and identical between BSD and GNU. A new parameter is added to `_autoenv_hash_pair` to specify the version, defaulting to the latest (2). It outputs a `cksum`-based hash for version 2 and `shasum`-based for version 1. Moves logic to check for an entry in `$AUTOENV_AUTH_FILE` into its own function (`_autoenv_authorized_pair`), as it may need to be called twice. Modifies `_autoenv_authorized_env_file` to check for v1 entries when v2 fails. Fixes Tarrasch#53. Alternative implementation to Tarrasch#54.
blueyed
pushed a commit
that referenced
this pull request
Jan 10, 2017
A new parameter is added to `_autoenv_hash_pair` to specify the version, defaulting to the latest (2). It outputs a `cksum`-based hash for version 2 and `shasum`-based for version 1. Moves logic to check for an entry in `$AUTOENV_AUTH_FILE` into its own function (`_autoenv_authorized_pair`), as it may need to be called twice. Modifies `_autoenv_authorized_env_file` to check for v1 entries when v2 fails. Fixes #53. Alternative implementation to #54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53.
We might to migrate existing checksums?!
Not sure if it's worth the effort though..