Fix warnings #23
Merged
Fix warnings #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvldskey_mlen() will always return a value which fits into (uint8_t). It
begins by setting
size_t mlen = 0
and then increments it until
mlen == kvldskey->(uint8_t len)
(or until the buffers do not match). The definition of `struct kvldskey` is in
lib/datastruct/kvldskey.h
Since the `len` field of `struct kvldskey` is uint8_t, it doesn't make sense to accept a larger buflen.
callback_read_header() waits until it has a complete header, or waits for more to arrive. That seems appropriate for the end of callback_connected(), so I don't think we need that extra return.
| @@ -15,12 +15,15 @@ kvldskey_create(const uint8_t * buf, size_t len) | |||
| { | |||
There was a problem hiding this comment.
I was tempted to change kvldskey_create to accept uint8_t buflen instead of size_t buflen since struct kvldskey stores uint8_t, but this strikes me as a "6 of one, half a dozen of the other" situation.
There was a problem hiding this comment.
Leaving the API as size_t is good. This way future bugs are more likely to be caught via the assertion rather than hidden by silent integer overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.