Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: mention scrypt_kdf() #278

Merged
merged 1 commit into from Sep 20, 2020
Merged

README: mention scrypt_kdf() #278

merged 1 commit into from Sep 20, 2020

Conversation

gperciva
Copy link
Member

No description provided.

@gperciva
Copy link
Member Author

Partially addresses #277 (if this is accepted, I'll update the website accordingly).

Original discussion about the public header for libscrypt-kdf is here:
#168 (comment)

My first instinct was to remove all mentions of crypto_scrypt() from that section, but historically people have used scrypt by copying files into their own project and calling that function. I don't know if we should try to discourage that now, so I opted for a "minimal" change of mentioning scrypt_kdf() in the context of the optional libscrypt-kdf.

@gperciva
Copy link
Member Author

Updated the PR to mention scrypt_kdf() first, and significantly downplay the "copy source files into your project" option. See it in action:
https://github.com/Tarsnap/scrypt/tree/discuss-scrypt-kdf#using-scrypt-as-a-kdf

@cperciva cperciva merged commit 6499883 into master Sep 20, 2020
@gperciva gperciva deleted the discuss-scrypt-kdf branch September 20, 2020 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants