Revamp CMake to be correct and easy to understand #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruxisma
changed the title
|
(nice) |
|
My apologies, still trying to get the configuration to work correctly. It's very difficult to debug what is happening with both travis and appveyor :/ |
🎨 Cleanup include path for catch2 ✨ Add basic .deb generation support WiX and RPM support is still needed (if even desired?) ⬆️ Upgrade minimum CMake version to 3.14 ⬆️ Upgrade Catch to Catch v2.9.2 📌 Pin Catch to v2.9.2
|
@TartanLlama checks are all set. Just needs your approval to merge :) |
TartanLlama
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎨 Cleanup include path for catch2
✨ Add basic .deb generation support
WiX and RPM support is still needed (if even desired?)
⬆️ Upgrade minimum CMake version to 3.14
⬆️ Upgrade Catch to Catch v2.9.2
📌 Pin Catch to v2.9.2
These changes come courtesy of our brief conversation we had. I will be doing the same for tl/optional soon. :)