Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Fix meta.canonical URL #3

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

@etu
Copy link
Member

etu commented Oct 19, 2023

Thanks!

I found it interesting why this happened because the sample json I based it upon is the one that resumed init gave me. So I've dug into it why this was wrong.

Turns out that the latest release of resume-schema is 1.0.0 and that release is like 3 years old. This is also used by resumed. In this version, the filename of the schema is actually resume.json. However, since 1.0.0 this filename has changed on master and therefore it doesn't exist anymore and this is why resumed gives a file with the wrong URL.

I will correct my samples here with your PR, but I will also forward reports upstream to the correct places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants