Closes #2491: Set Owner of Task when Transferring #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
5 times, most recently
from
999b007
to
171399d
Compare
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
2 times, most recently
from
80c00dd
to
537fa89
Compare
|
The discussions took place in the closed PR for the same issue: #2495 |
ryzheboka
requested changes
Apr 23, 2024
...y-provider/src/test/java/acceptance/events/task/CreateHistoryEventOnTaskTransferAccTest.java
Outdated
Show resolved
Hide resolved
lib/taskana-core/src/main/java/pro/taskana/task/api/TaskService.java
Outdated
Show resolved
Hide resolved
lib/taskana-core/src/test/java/acceptance/task/transfer/TransferTaskAccTest.java
Show resolved
Hide resolved
rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskController.java
Outdated
Show resolved
Hide resolved
...n/java/pro/taskana/task/rest/assembler/BulkOperationResultsRepresentationModelAssembler.java
Outdated
Show resolved
Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java
Show resolved
Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java
Outdated
Show resolved
Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java
Show resolved
Hide resolved
...va/pro/taskana/task/rest/assembler/BulkOperationResultsRepresentationModelAssemblerTest.java
Outdated
Show resolved
Hide resolved
...va/pro/taskana/task/rest/assembler/BulkOperationResultsRepresentationModelAssemblerTest.java
Outdated
Show resolved
Hide resolved
I checked it again and cannot find the issues introduced by new code |
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
2 times, most recently
from
51d6779
to
c0df871
Compare
ryzheboka
reviewed
Apr 25, 2024
...va/pro/taskana/task/rest/assembler/BulkOperationResultsRepresentationModelAssemblerTest.java
Outdated
Show resolved
Hide resolved
You are right! |
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
2 times, most recently
from
d2ec2d3
to
cca8a7a
Compare
ryzheboka
reviewed
Apr 30, 2024
...va/pro/taskana/task/rest/assembler/BulkOperationResultsRepresentationModelAssemblerTest.java
Outdated
Show resolved
Hide resolved
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
from
cca8a7a
to
79d8d68
Compare
holgerhagen
requested changes
May 8, 2024
| * transferred | ||
| * @param destinationWorkbasketId the {@linkplain Workbasket#getId() id} of the target {@linkplain | ||
| * Workbasket} | ||
| * @return the transferred {@linkplain Task} |
There was a problem hiding this comment.
Isn't the boolean parameter missing?
There was a problem hiding this comment.
This transfer() function does not have the setTransferFlag() boolean parameter, but it calls another transfer() function that has the boolean parameter. It does not make sense to include the boolean parameter here, since it does not directly have the boolean parameter.
| * transferred | ||
| * @param workbasketKey the {@linkplain Workbasket#getKey() key} of the target {@linkplain | ||
| * Workbasket} | ||
| * @param domain the {@linkplain Workbasket#getDomain() domain} of the target {@linkplain |
| /** | ||
| * Transfers a List of {@linkplain Task Tasks} to another {@linkplain Workbasket} while always | ||
| * setting {@linkplain Task#isTransferred isTransferred} to true. | ||
| * | ||
| * @param destinationWorkbasketId {@linkplain Workbasket#getId() id} of the target {@linkplain | ||
| * Workbasket} | ||
| * @param taskIds List of source {@linkplain Task Tasks} which will be moved |
| * @param destinationWorkbasketKey target {@linkplain Workbasket#getKey() key} | ||
| * @param destinationWorkbasketDomain target {@linkplain Workbasket#getDomain() domain} | ||
| * @param taskIds List of source {@linkplain Task Tasks} which will be moved | ||
| * @return Bulkresult with {@linkplain Task#getId() ids} and Error for each failed transactions |
jamesrdi
force-pushed
the
TSK-2491-BackupNew
branch
from
79d8d68
to
d6f2590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sonarcloud.io/summary/new_code?id=jamesrdi_taskana&branch=TSK-2491-BackupNew
Release Notes:
For the submitter:
Verified by the reviewer: