Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message generation stability #90

Merged
merged 5 commits into from
Apr 7, 2024
Merged

fix: message generation stability #90

merged 5 commits into from
Apr 7, 2024

Conversation

jameszyao
Copy link
Contributor

Pull Request

PR Description

  1. fix: add wildcard in provider model types
  2. fix: raise message generation error when model not found
  3. fix: remove JSONDecodeError log in chat_completion_stream
  4. fix: auto restart redis client

Linked Issue

Resolves #82 #80 #41

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING.md guidelines.
  • I have tested my changes locally to ensure they are effective.
  • I have updated the necessary documentation (if applicable).

@jameszyao jameszyao requested a review from SimsonW April 5, 2024 13:31
@jameszyao jameszyao added the bug Something isn't working label Apr 5, 2024
SimsonW
SimsonW approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@SimsonW SimsonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SimsonW SimsonW merged commit f532182 into master Apr 7, 2024
1 check passed
@jameszyao jameszyao deleted the fix/message-generation-stability branch April 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimsonW SimsonW SimsonW approved these changes

@taskingaijc taskingaijc Awaiting requested review from taskingaijc

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chat completion stream JSONDecodeError
3 participants
@jameszyao @SimsonW @taskingaijc