Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tool result size check #92

Merged
merged 2 commits into from
Apr 7, 2024
Merged

feat: add tool result size check #92

merged 2 commits into from
Apr 7, 2024

Conversation

jameszyao
Copy link
Contributor

@jameszyao jameszyao commented Apr 5, 2024 •
edited

Pull Request

PR Description

add tool result size check to prevent the context length from becoming too large

Linked Issue

#86

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING.md guidelines.
  • I have tested my changes locally to ensure they are effective.
  • I have updated the necessary documentation (if applicable).

@jameszyao jameszyao self-assigned this Apr 7, 2024
@jameszyao jameszyao added the enhancement New feature or request label Apr 7, 2024
@taskingaijc taskingaijc force-pushed the feat/add-tool-result-length-check branch from 4b4f8b4 to 345547b Compare April 7, 2024 13:21
@taskingaijc taskingaijc force-pushed the feat/add-tool-result-length-check branch from 345547b to 0e30572 Compare April 7, 2024 13:28
@taskingaijc taskingaijc force-pushed the feat/add-tool-result-length-check branch from 0e30572 to b1b6e2f Compare April 7, 2024 13:41
@taskingaijc taskingaijc removed the request for review from SimsonW April 7, 2024 13:45
taskingaijc
taskingaijc approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@taskingaijc taskingaijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taskingaijc taskingaijc merged commit 83af1d7 into master Apr 7, 2024
1 check passed
@jameszyao jameszyao deleted the feat/add-tool-result-length-check branch April 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taskingaijc taskingaijc taskingaijc approved these changes

Assignees

@jameszyao jameszyao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jameszyao @taskingaijc