Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position feature, ID, AutoScan, csv file, etc. #678

Open
alexdelprete opened this issue Oct 6, 2022 · 10 comments
Open

Position feature, ID, AutoScan, csv file, etc. #678

alexdelprete opened this issue Oct 6, 2022 · 10 comments

Comments

@alexdelprete
Copy link

While readding all my tasmota devices (40 of them) through AutoScan, I had some difficulties:

  1. often many devices were not found, even if available/pingable/browsable. Retrying using the specific IP of the device found them right away.
  2. after the painful AutoScan process ended, I found the devices being added in a weird way, so I wanted to sort the list using the column headers, but wasn't able to. Sorting is definitely important if you have many devices, when troubleshooting etc.
  3. I tried to sort/fix the device list manually editing the csv file but I found out that the process wasn't easy as I thought: sometimes TA didn't pickup the changes or reported NO DEVICES. Luckily I backed up the file before editing it. Could TA support mysql/sqlite for data?
  4. the energy column as it is is not very usable, no labels so no way of interpreting the values. I know it's difficult because there's not enough space but you devs are clever and I bet you have a solution for that. :)

I know I mixed Feature Requests with probably some Issues, I hope you can pardon me. :)

Thanks for this amazing tool.

@inverse
Copy link
Collaborator

inverse commented Oct 10, 2022

This is a loaded ticket :) but def something that needs some improvements!

  1. What do you think would be a good suggestion for this one? Perhaps It could run a multi-pass check over the defined range? Not sure if we would hit and request timeouts?
  2. Do you mean once they have been added ? What do you mean by in a weird way?
  3. Yeah that CSV file is very clunky and error prone - sqlite would be a nice addition here
  4. Would you like some labels explaining each row in that field? or are you after something else?

Thanks for the feedback :) I'm just picking up where reloxx13 took this project!

@alexdelprete
Copy link
Author

alexdelprete commented Oct 10, 2022

It was a brainstorming ticket. Sorry. :)

  1. A more robust scanning process with a dynamic log window (like autoupdate) in which: TA pings the IP several times (5 maybe) and logs the result, if ping ok checks if it's a tasmota device and logs, if it fails retries a 2nd time just in case. The trick is providing a log, otherwise I can't understand why it fails to pickup devices sometimes, unless I feed it the single ip of the device.
  2. They were being added not by IP...sometimes yes but sometimes not. Don't ask me why. And reordering the list for me is not really intuitive, I'd simply love to sort by the column headers.
  3. sqlite is ok, but also mysql/mariadb (my preference). I got bad experiences with sqlite when it corrupts.
  4. If there's space, maybe in the detailed view, adding labels would be helpful. I have SHelly EMs with two energy sensors, and trust me it's a mess reading those values. :) maybe hovering with the mouse in non-detailed view and adding all labels in detailed view?

Thank you so much. :)

@inverse
Copy link
Collaborator

inverse commented Nov 4, 2022

@alexdelprete Found out the plugin we use can handle sortable...

image

It's very basic but can function what columns did you want sortable and how so? I can add the basic ones by string and int for the pos...

@alexdelprete
Copy link
Author

Name

t's very basic but can function what columns did you want sortable and how so?

Great news. I'd say: Name, IP, RSSI, Version...should be enough for now. :)

@inverse
Copy link
Collaborator

inverse commented Nov 5, 2022

@alexdelprete pushed https://github.com/TasmoAdmin/TasmoAdmin/releases/tag/v2.2.0-beta.1 for you to play with - should be ready in a few minutes via docker.

@netstx
Copy link

netstx commented Nov 5, 2022

Thanks @inverse :) Sorting is going to be really useful

@alexdelprete
Copy link
Author

@alexdelprete pushed https://github.com/TasmoAdmin/TasmoAdmin/releases/tag/v2.2.0-beta.1 for you to play with - should be ready in a few minutes via docker.

Sorting is not working perfectly, I sorted on wifi signal:

Top of the list:
image

Middle of the list:
image

Bottom of the list:
image

@inverse
Copy link
Collaborator

inverse commented Nov 5, 2022

@alexdelprete my bad - forgot the data-tablesaw-sortable-numeric attribute on that column

@inverse
Copy link
Collaborator

inverse commented Nov 5, 2022

New beta build should fix that https://github.com/TasmoAdmin/TasmoAdmin/releases/tag/v2.2.0-beta.2

@alexdelprete
Copy link
Author

Thanks, works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants