Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I wonder if it would be easy to add a "horizontal rule" <hr /> before the first indirect translation. #1874

Open
ckjpn opened this issue Apr 26, 2019 · 4 comments
Assignees
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.

Comments

@ckjpn
Copy link

ckjpn commented Apr 26, 2019

I wonder if it would be easy to add a "horizontal rule"


before the first indirect translation. That would likely make it clearer where the "indirect translations" start.

If so, that might help new members more easily realize that some of the sentences are "translations of translations."

If it's not hard to do, then this might be worth the effort, since the new layout is taking a long time to implement.

This was on the Wall today.

https://tatoeba.org/eng/wall/show_message/31764#message_31764

@jiru jiru added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Apr 27, 2019
@ckjpn
Copy link
Author

ckjpn commented Jun 5, 2019

I don't have things set up yet to do a pull request, but if I go into the code and figure out where the <hr /> needs to be inserted, would someone be willing to insert this into what's being used on tatoeba.org.

@jiru
Copy link
Member

jiru commented Jun 5, 2019

Your coding help is certainly welcome, but I think the real problem is not about finding where in the code to put the hr tag. It is more about how to make a design that is less confusing (the hr tag being one of the possible solutions). Writing code is easy, but writing code that works well is much harder.

If I just put an hr tag in there, here is how it looks:

Screenshot_2019-06-05 Turkish example sentence Tom'u bize yardım ettirmek istiyorum - Tatoeba

Now I feel like the "translations of translations" part became a whole separate section independent from the main sentence itself.

I am not very comfortable when it comes to designing interfaces. If you have better ideas, and if you can express them using images instead or HTML tags, I am all ears.

@trang
Copy link
Member

trang commented Jun 7, 2019

This is an issue I already tried to solve in the new design. If we decide that it's worth investing time into changing the old sentence's design instead of investing that time to into finishing the new sentence design, then I would suggest to use the same pattern as in the new design. This would help confirming that the new design works, so it wouldn't be a waste of time to rework the old sentence design.

The pattern would be:

  • Add a separator below the main sentence (light grey).
  • Add a label "Translations" above the translations.
  • Add a label "Translations of translations" above the indirect translations.

The labels is what help people realize that grey sentences are indirect translations. I used "Translations of translations" as a label because I felt that for completely new users, "indirect translations" may not be completely clear. At least to me, it feels a bit more technical.

We could also add a separator below the group of direct translations, but I think the label already serves as some sort of separator.

On the other hand, we could remove the separator below the main sentence, but I feel it helps to emphasize that the main sentence is an element on its own, so that contributors are less tempted to edit a sentence just so that it fits the translations.

Screenshot of how the new design looks like:

90efea3744e1065700574eb13f5667f5

@ckjpn
Copy link
Author

ckjpn commented Jul 2, 2019

Perhaps, at least temporarily, you add this in so people currently using the site can more easily understand what's happening.

I'm not sure that the label "Translations" is necessary since they are obviously translations, but you could likely easily add something like the following in to help people easily understand what's going on.

<hr />
Translations of translations (These may not match.)
<hr />

Screen Shot 2019-07-02 at 15 27 48

Related Wall post today.
https://tatoeba.org/eng/wall/index#message_32141

Afterthought:
"These may not match" wouldn't work when there is only one indirect translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

No branches or pull requests

3 participants