Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken UI translations #657

Closed
jiru opened this issue May 16, 2015 · 0 comments
Closed

Broken UI translations #657

jiru opened this issue May 16, 2015 · 0 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Milestone

Comments

@jiru
Copy link
Member

jiru commented May 16, 2015

There are strings that are simply dropped and remain untranslated whatever you do. For instance, the string “Create a new list” visible in the sentences list page.

The reason is that it’s followed by a msgctxt string in the .po file. The string “Birthday” is also concerned along with the strings that have a msgctxt themselves. So four strings in total remains untranslated.

The problem appeared when I dropped .mo files. When we were using .mo files, CakePHP relied on these to get the translations and ignored the .po files. In .mo files, msgctxt strings are simply prefixed with a tab to the msgid string (i.e. msgctxt + "\t" + msgid) to create the unique key, which normally consists of only the msgid string. This implementation detail allowed us to use msgctxt strings without explicit support for them in CakePHP. But now CakePHP fails to read .po files properly because it’s not msgctxt-aware.

@jiru jiru added the bug Issue that describes a problem with a feature that doesn't work as expected. label May 16, 2015
@trang trang added this to the UI strings milestone Jun 2, 2015
@jiru jiru closed this as completed in a47dde2 Jun 6, 2015
@trang trang modified the milestones: 2015-06-06, UI strings Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

2 participants