-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
games-emulation/rpcs3 - Needs patch for LLVM 17 Systems #259
Comments
Related: #259 Signed-off-by: Andrew Udvare <audvare@gmail.com>
Can you try the change I just pushed? The issue is that |
I |
Please confirm you have the latest ebuild. You should get same output as below:
(Fix ebuild path as necessary.) |
RPCS3/rpcs3#15075 Related: #259 Signed-off-by: Andrew Udvare <audvare@gmail.com>
I switched to Clang and matched your USE flags in my testing and I still cannot reproduce this issue. It looks like adding includes will solve it but I am not so sure. Please try the -r3 version where I have included an adapted patch from RPCS3/rpcs3#15075. This looks like it may solve the issue assuming no other includes are required. |
I ran that but it didn't return any output.
I re-synced, and the ebuild updated to r3 but the build still fails; which is odd, because that patch you mentioned that links to the original Guru bug page I filed does work with guru's 9999 ebuild to finish emerging, so I don't understand why it wouldn't work here. |
Please post the latest build log. |
Sorry about that, I meant to but hit |
Related: #259 Signed-off-by: Andrew Udvare <audvare@gmail.com>
I think I figured out the issue. My version is too old for that exact patch in the PR. JIT.cpp was renamed since then so it never gets patched to include the needed header. I have rebased and remade the patches including the one in the PR. I think this should fix it. My patches were a little wonky. I think this is related to a transient header issue since I don't get the issue on my machines. Somehow my toolchain is implicitly including |
This seems to work now, yeah. 👍
As far as I can tell from the log, it just isn't adding the new folder path and seems to be crashing because it wasn't expecting it to be empty. Correct me if I'm wrong though. |
I get the same crash. Definitely a bug on the part of RPCS3. However, they probably disable assertions in their builds so nobody sees this. You will have to edit Closing this. Thanks for reporting and testing this. |
@Tatsh One last thing, about that, the correct path is already in |
The Guru package has a bug related to this (https://bugs.gentoo.org/922263), but I wanted to report here that the patch that solves this issue over there for the live ebuild doesn't work for this overlay's package to get the emulator to build.
Log (without patch): rpcs3-tatsh-build.log
The text was updated successfully, but these errors were encountered: