Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

респрайт коктейлей #8185

Merged
merged 6 commits into from Nov 13, 2021
Merged

респрайт коктейлей #8185

merged 6 commits into from Nov 13, 2021

Conversation

AndroBetel
Copy link
Member

Описание изменений

image
Зареспрайчена большая часть коктейлей, шейкер и пакетики с соком.

Почему и что этот ПР улучшит

K P A C U B O

Авторство

DedYarick

Чеинжлог

🆑DedYarick

  • image: Респрайт коктейлей.

@TauKitty
Copy link
Contributor

TauKitty commented Nov 9, 2021

Changelog status: ✔️

UDaV73rus
UDaV73rus reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@UDaV73rus UDaV73rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
дубликат

UDaV73rus
UDaV73rus reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@UDaV73rus UDaV73rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
не центрировано

@AndroBetel
Copy link
Member Author

Там анимация дымка вверх улетающего.

@AndroBetel
Copy link
Member Author

Дубликат исправлен.

UDaV73rus
UDaV73rus suggested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@UDaV73rus UDaV73rus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Стаканчик всё-таки нужно центрировать, дымку не сложно будет подогнать под границы
image
Ещё вопросы по форме бокальчиков, если сделать верх также как ножку по форме, разве будет хуже?
Думаю стоит сделать как ножку

UDaV73rus
UDaV73rus suggested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@UDaV73rus UDaV73rus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ещё нашел что у многих стаканчиков слишком повернутая перспектива
image
У мелких стаканчиков два пикселя по бокам, а у многих больших стаканов три. Сделай везде два тогда...

@KIBORG04
Copy link
Member

Чё с ним?

R8E0rNu55N.mp4

@UDaV73rus
Copy link
Member

баг диффа

@AndroBetel
Copy link
Member Author

image
image
Изменено по заявкам.

UDaV73rus
UDaV73rus approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@UDaV73rus UDaV73rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

найс кок

@SpaiR
Copy link
Member

SpaiR commented Nov 13, 2021

@AndroBetel
У тебя в списке измененных стейтов есть два, в самом конце: shaker-2 и red_meadglass-2. Какая-то ошибка или для чего-то нужны?

@AndroBetel
Copy link
Member Author

Походу ошибка, щас посмотрю.

@AndroBetel
Copy link
Member Author

Во.

@SpaiR SpaiR merged commit 21078fe into TauCetiStation:master Nov 13, 2021
TauKitty added a commit to TauCetiStation/ClassicChangelog that referenced this pull request Nov 13, 2021
@TauKitty
Automatic changelog generation for PR TauCetiStation/TauCetiClassic#8185
b72110d
@Millanister
Copy link

WTF

@TauKitty
Copy link
Contributor

This pull request has been mentioned on Tau Ceti Station Forum. There might be relevant details there:

https://forum.taucetistation.org/t/vernut-starye-napitki-golosovanie/29930/1

@AndroBetel AndroBetel deleted the cock_tails branch March 1, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UDaV73rus UDaV73rus UDaV73rus approved these changes

Assignees
No one assigned
Labels
Sprites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndroBetel @TauKitty @KIBORG04 @UDaV73rus @SpaiR @Millanister