New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GPS minimum tests in Attitude module #2192

Open

kubark42 opened this issue Feb 18, 2016 · 1 comment

Labels

enhancement firmware new dev task

Contributor

kubark42 commented Feb 18, 2016

There are bunches of
if ((gpsData.Satellites >= 6) && (gpsData.PDOP <= 4.0f))

and
if ((gpsData.Satellites < 6) && (gpsData.PDOP > 4.0f))

and
if ((gpsData.Satellites >= 7) && (gpsData.PDOP <= 3.5f))

in at least:

Modules/Attitude/attitude.c
Modules/GPS/GPS.c

These should be grouped into a simple test function (or two functions).

The text was updated successfully, but these errors were encountered:

kubark42 added enhancement new dev task firmware labels

Contributor

peabody124 commented Feb 18, 2016

Agreed about consolidating. Just let's keep some kind of hysteresis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment