-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Based TV Show Support #1503
Conversation
You don't need all the |
I know it is already in the ISO Format. The idea was to keep it in line with the current style (seasons have the dots |
@JonnyWong16 So we can complete/progress this Pull Request. I first tried to contact you via a Discord PM as I would have liked to not clutter up the PR with a message like this. |
The date format you see in Plex is based on locale. It will use a dot, dash, or a slash and a different order of year, month, and day depending on where you set your location. In Tautulli, since there is no localization, the date could be
For Discord, you can just use the |
We should either go with 1. or 3. as 2. would be nothing complete (users can choose but not on a sufficent level). So from my perspective:
3 Add a new "Date-Based Episode Format"
I tend to 3. to give users one more option from the start, but I would like to know your opinion.
|
I need to think about the newsletter. Let's go with option 3, a separate setting for "Date-Based Episode Format". |
Any decision/news about the newsletter? |
I'm thinking just the range of dates for the newsletter.
|
Sounds good and seems like the cleanest solution. |
@@ -502,6 +502,7 @@ | |||
{'name': 'Season Number', 'type': 'int', 'value': 'season_num', 'description': 'The season number.', 'example': 'e.g. 1, or 1-3'}, | |||
{'name': 'Season Number 00', 'type': 'int', 'value': 'season_num00', 'description': 'The two digit season number.', 'example': 'e.g. 01, or 01-03'}, | |||
{'name': 'Episode Number', 'type': 'int', 'value': 'episode_num', 'description': 'The episode number.', 'example': 'e.g. 6, or 6-10'}, | |||
{'name': 'Episode Number', 'type': 'str', 'value': 'episode_date', 'description': 'The episode number of date based tv shows (in date format).'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide a additional notifier variable episode_date
that is only used for date based tv shows or extend the description of episode_num
that in case of a date based tv show shows the air date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already an air_date
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but in case of a item that uses the date based
system episode_num
and episode_num00
will be replaced with originally_available_at
. Should we include this in the notifier description? That was the idea behind this question/change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, don't change the behaviour of episode_num
(in this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will work on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave it a thought, how would you propose to implement the notifications for date based tv show?
If the user uses episode_num
and hits a on date based episode the variable then should use the originally_available_at
as its currently implemented from a logic standpoint in my opinion.
Continued with PR #1960. This PR is outdated and marked as draft. |
Description
Continued with PR #1960. This PR is outdated and marked as draft.
This PR aims to fix issue #1487 and provide a place where we can work & discuss on this topic.
UI fields needing a change/fixed:
Please report any occurrences of this issue that aren't listed above.
Screenshot
Type of Change
Checklist