Multiselect user filters #2090
Merged
Multiselect user filters #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use standard concatenation Fix select style Move settings to JS constructor Change text for no users checked Don't call selectAll on page init Add it back Remove attributes Fix emptiness check Allow deselect all Only refresh if user id changed
JonnyWong16
requested changes
Jul 7, 2023
Co-authored-by: JonnyWong16 <9099342+JonnyWong16@users.noreply.github.com>
Co-authored-by: JonnyWong16 <9099342+JonnyWong16@users.noreply.github.com>
I pushed the minor changes, and added the picker to the history page (tested locally, works perfectly) |
5 tasks
JonnyWong16
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, user filtering was limited to seeing stats for either one user or all users. This was seen as an issue especially for the quite common case of one Plex user being a "power user" and using Plex a lot more than the others. Excluding an user, or, more generally, filtering for multiple users, appears as something useful.
This PR replaces the old, simple <select>-based filter by one using Bootstrap-select that allows multiple selection.
The changes in the frontend are limited to graphs.html, the main stylesheet, and the addition of the Bootstrap-select vendor files.
The changes in the backend are limited to graphs.py (the graph APIs) and webserve.py (the exposed API functions).
Screenshot
Issues Fixed or Closed
Type of Change
Please delete options that are not relevant.
Checklist
(this PR should be squashed when merged)