Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quater values for History Watch Status #2179

Merged
merged 5 commits into from Oct 23, 2023

Conversation

herby2212
Copy link
Contributor

Description

Introduces quarter values to the watch status.

The existing calculation in the datafactory was extended to account for the new status options. The history_table was changed from using FontAwesome icons to a custom css class (I took your example there as a basis).

Screenshot

Before
image

After
image

Include screenshots if the changes are UI-related.

Issues Fixed or Closed

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods

@JonnyWong16
Copy link
Contributor

Can you fill the circle clockwise?

  • Quarter: top-right
  • Half: top-right and bottom-right
  • Three Quarters: top-right, bottom-right, and bottom-left
  • Full: full

@herby2212
Copy link
Contributor Author

Can you fill the circle clockwise?

  • Quarter: top-right
  • Half: top-right and bottom-right
  • Three Quarters: top-right, bottom-right, and bottom-left
  • Full: full

It should already be this way.

@JonnyWong16
Copy link
Contributor

image

@JonnyWong16
Copy link
Contributor

Oh my bad dark is empty, white is full.

Half circle is still backwards.

@herby2212
Copy link
Contributor Author

Oh my bad dark is empty, white is full.

Half circle is still backwards.

Yeah half circle is the wrong way around 😄. I will change it.

@herby2212
Copy link
Contributor Author

Oh my bad dark is empty, white is full.
Half circle is still backwards.

Yeah half circle is the wrong way around 😄. I will change it.

Done.

@JonnyWong16
Copy link
Contributor

Left is new, right is old. Circle is floating above the baseline. Change the light colour (border and full) to #eeeeee and dark colour (partially filled) to #2b2b2b to match the old icons.

image

@herby2212
Copy link
Contributor Author

Left is new, right is old. Circle is floating above the baseline. Change the light colour (border and full) to #eeeeee and dark colour (partially filled) to #2b2b2b to match the old icons.

image

Done.

@JonnyWong16 JonnyWong16 merged commit a31dcb5 into Tautulli:nightly Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants