MINOR REFACTOR #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made some minor refactors like
Changed a direct reference to the User model to AUTH_USER_MODEL for models.py and get_user_model anywhere else. This is better incase you change the User model (maybe to add extra fields) you would not have to make the change every else you used the User model. instead you just point to the new User model in the settings.py (AUTH_USER_MODEL="".
Change the flutterwave private and secret key variables in settings.py to uppercase to follow the django convention.
Change all direct reference to settings.py file to a dynamic reference (i.e from donaypay.settings to from django.conf import settings). This way is better because in a situation that the settings.py file is moved due to refactoring (maybe split into a different files for production, local and test) you would not have to go and make the changes everywhere you referenced the settings file directly.
Removed some else statement that were not necessary because of the return statement at if the condition is met.
Removed @staticmethod from the authenticate_user() method of LoginSerializer to have access to the validated_data so you do not have to pass the validated data again in the view.
Removed the main app because it's not doing anything.