Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HelpParams::proglineShowFlags #42

Merged
merged 2 commits into from Nov 12, 2017
Merged

Add HelpParams::proglineShowFlags #42

merged 2 commits into from Nov 12, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2017

HelpParams::proglineShowFlags adds actual flags instead of string '{OPTIONS}'. Flags are added as --value-flag <NAME> or --bool-flag. Non-required flags are surrounded by brackets.

HelpParams::proglinePreferShortFlags tries to use short flag names in usage.

I also removed brackets for required positional arguments.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.452% when pulling a86c29b on pavel-belikov:better-progline into 3331ae4 on Taywee:master.

@Taywee
Copy link
Owner

Taywee commented Nov 12, 2017

Yeah, that's a good idea. Passing up the strings the way I did was really a quick hack that I hadn't intended to stick around.

@Taywee Taywee merged commit b8fc0d9 into Taywee:master Nov 12, 2017
@ghost ghost deleted the better-progline branch November 12, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants