Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Casing] Change default from verbatim to kebab. #204

Merged
merged 1 commit into from Jun 19, 2019

Conversation

0ndorio
Copy link
Contributor

@0ndorio 0ndorio commented Jun 17, 2019

.. fixes #202

I hope I discovered all related comments and text snippets.

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 18, 2019

Thanks. Will try to review today.

Please update the changelog.

@0ndorio 0ndorio force-pushed the task/change_default_casing_to_kebab branch from 8545506 to f894b55 Compare June 18, 2019 07:48
@0ndorio
Copy link
Contributor Author

0ndorio commented Jun 18, 2019

Thanks. Will try to review today.

Please update the changelog.

Done. Listed it inside the Breaking Changes category.

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 18, 2019

Sorry to not been explicit enough: can you add a note in the changelog explaining how to have the same behavior as before, for ease of upgrading? Thanks.

That's basically adding #[structopt(rename_all = "verbatim") where you have #[derive(StructOpt)]

Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the documentation at the begining of lib.rs, explaining that, by default, long, short name and commands without explicit name will be renamed using kebab-case if rename-all is not specified.

Else, everything looks good, thanks!

@0ndorio 0ndorio force-pushed the task/change_default_casing_to_kebab branch from f894b55 to 2f015e6 Compare June 18, 2019 17:10
@0ndorio
Copy link
Contributor Author

0ndorio commented Jun 18, 2019

Please improve the documentation at the begining of lib.rs, explaining that, by default, long, short name and commands without explicit name will be renamed using kebab-case if rename-all is not specified.

Else, everything looks good, thanks!

Updated the change log and added an additional paragraph to describe the behavior (I hope it's in the right place).

@TeXitoi TeXitoi merged commit 2a36783 into TeXitoi:master Jun 19, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Jun 19, 2019

Thanks!

@0ndorio 0ndorio deleted the task/change_default_casing_to_kebab branch June 22, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default case modification to kebab-case
2 participants