Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit dummy impls on error #248

Merged
merged 3 commits into from Sep 2, 2019
Merged

Emit dummy impls on error #248

merged 3 commits into from Sep 2, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

Closes #240

Also I moved tests/ui to tests/ui-common.

I'm not sure what to write in changelog, could use your guidance here

TeXitoi
TeXitoi approved these changes Sep 2, 2019
View reviewed changes
Copy link
Owner

@TeXitoi TeXitoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "Remove useless error message when a meaningful error is generated"?

@CreepySkeleton
Copy link
Collaborator Author

Changelog updated + rebased. Ready to go in

@TeXitoi TeXitoi merged commit 40e9ab4 into TeXitoi:master Sep 2, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Sep 2, 2019

Thanks!

@CreepySkeleton CreepySkeleton deleted the dummy_impl branch September 3, 2019 08:06
@epage epage mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit dummy StructOpt impl when reporting errors
2 participants
@CreepySkeleton @TeXitoi