Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #269 and #265 #278

Merged
merged 4 commits into from Nov 8, 2019
Merged

Fix #269 and #265 #278

merged 4 commits into from Nov 8, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

@CreepySkeleton CreepySkeleton commented Nov 4, 2019 •
edited

Closes #269 #265
Single PR because this changes are on top of one another

TeXitoi
TeXitoi reviewed Nov 4, 2019
View reviewed changes
structopt-derive/src/attrs.rs Show resolved Hide resolved
structopt-derive/src/attrs.rs Outdated Show resolved Hide resolved
structopt-derive/src/parse.rs Outdated Show resolved Hide resolved
structopt-derive/src/spanned.rs Show resolved Hide resolved
@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Nov 4, 2019 •
edited

I'll be adding fixes as new commits, once you're happy with the PR I'll rebase to get clean 3-commits PR

@CreepySkeleton
Copy link
Collaborator Author

OK, @TeXitoi , now it's as simple as I can manage, tell me if you have any more ideas. Also, just released rustc 1.39 changed error message format a bit so I set it to ignore ui tests on pre-1.39, is that OK?

@TeXitoi TeXitoi merged commit b5907e8 into TeXitoi:master Nov 8, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Nov 8, 2019

Great, thanks!

@TeXitoi
Copy link
Owner

TeXitoi commented Nov 8, 2019

v0.3.4 published.

@TeXitoi
Copy link
Owner

TeXitoi commented Nov 8, 2019

@CreepySkeleton Do you want to be official contributor of structopt? If yes, I give you commit access to this repository. No pressure, just I will make PR and you'll have to read and merge them, but no other engagements.

@CreepySkeleton
Copy link
Collaborator Author

@TeXitoi I agree with pleasure 😄 Just be aware that I can't guarantee any determinate involvement/ping time. Normally, I should be able to reply in ~5 hours but life get complicated sometimes.

@CreepySkeleton CreepySkeleton mentioned this pull request Nov 8, 2019
Closed
@TeXitoi
Copy link
Owner

TeXitoi commented Nov 8, 2019

No pressure.

@epage epage mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raw ident for struct member prefixes "r-" to parameter and value names
2 participants
@CreepySkeleton @TeXitoi