Handle inter-expansion top-level args properly #290
Merged
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
force-pushed
the
app_methods
branch
from
3413004
to
f66a8ea
Compare
TeXitoi
approved these changes
Dec 3, 2019
|
@TeXitoi What's breaking about it? |
|
just doing a cargo update will change the behavior of the program as the top level annotations of parent types will be executed. |
Well, I really doubt someone out there would put an attribute and expect it not to apply :) |
|
That's why i'm OK with that, but it can happen as someone might tests some things and do not remove top level attribute but is happy with the result. |
|
It can be considered as a bug. |
You don't exactly expect such careless programming yield good results :) |
|
Welcome to the real world! ;-) |
Veetaha
reviewed
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
Fixes #289
Fixes #113