Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce #[structopt(rename_all_env)] #302

Merged
merged 2 commits into from Dec 14, 2019
Merged

Introduce #[structopt(rename_all_env)] #302

merged 2 commits into from Dec 14, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

@CreepySkeleton CreepySkeleton commented Dec 5, 2019 •
edited

Closes #149

@CreepySkeleton CreepySkeleton force-pushed the rename_all_env branch 2 times, most recently from 1ca22d7 to 11c1775 Compare December 6, 2019 09:48
@CreepySkeleton
Copy link
Collaborator Author

cc @TeXitoi ready for review

TeXitoi
TeXitoi reviewed Dec 9, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
tests/rename_all_env.rs Show resolved Hide resolved
@CreepySkeleton @TeXitoi
Update src/lib.rs
076321f 
Co-Authored-By: Guillaume P. <TeXitoi@users.noreply.github.com>
@CreepySkeleton CreepySkeleton changed the title WIP: Introduce #[structopt(rename_all_env)] Introduce #[structopt(rename_all_env)] Dec 9, 2019
@CreepySkeleton
Copy link
Collaborator Author

@TeXitoi so what do you think about this?

@TeXitoi
Copy link
Owner

TeXitoi commented Dec 11, 2019

I'm just septic on the advantage of having rename_all_env on a field, but you're right, that the good name for it.

@CreepySkeleton CreepySkeleton merged commit 61065d0 into master Dec 14, 2019
@CreepySkeleton CreepySkeleton deleted the rename_all_env branch December 14, 2019 09:50
@epage epage mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeXitoi TeXitoi TeXitoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename_all for env vars
2 participants
@CreepySkeleton @TeXitoi