Flatten for enums #334
Merged
Flatten for enums #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b678b05.
Co-Authored-By: CreepySkeleton <creepy-skeleton@yandex.ru>
Co-Authored-By: CreepySkeleton <creepy-skeleton@yandex.ru>
… into flatten-for-enums
|
No problem, I really don't mind either way. But now you have a lot of WIP in your master branch. I would have squash-merged that if I were you. Do you plan to do a release? |
|
They are behind a merge commit, who cares about them? The release is coming soon. |
|
I prefer to squash in this case but that's not really important. |
|
0.3.8 published |
It looks pretty horrible in the git logs and I feel ashamed 😭 😂 but thanks! I learned a lot and you have been incredibly helpful |
|
@cecton Thanks for contributing! It's both nice and horrifying to hear that someone has managed to learn from this pile of garbage we call codebase... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving merge conflicts in #329
@cecton, your authorship is preserved, sorry again for the mess.