Allow #[flatten] fields to have doc comments but ignore them (comments) #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeXitoi
reviewed
Jul 25, 2020
| @@ -1,4 +1,4 @@ | |||
| error: methods and doc comments are not allowed for flattened entry | |||
| error: methods are not allowed for flattened entry | |||
There was a problem hiding this comment.
Wasn't the goal to ignore the doc comment? Here, the compilation fail.
There was a problem hiding this comment.
The goal is to ignore the comments, but disallow methods with flatten, like short. This is exactly what triggers it here.
/// Comments allowed
#[structopt(flatten)]
// Methods disallowed
#[structopt(flatten, short)]
TeXitoi
approved these changes
Jul 25, 2020
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 6, 2021
TeXitoi/structopt#414 was ported in a951958 but the test was less exhaustive. This updates our test to match structopt's latest version of the test. This is a part of clap-rs#2809
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 7, 2021
TeXitoi/structopt#414 was ported in a951958 but the test was less exhaustive. This updates our test to match structopt's latest version of the test. This is a part of clap-rs#2809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411