Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling deleted user attendance data #232

Closed
ankitshah811 opened this issue Sep 25, 2014 · 4 comments
Closed

Handling deleted user attendance data #232

ankitshah811 opened this issue Sep 25, 2014 · 4 comments
Labels

Comments

@ankitshah811
Copy link
Member

How can we prevent this from happening? Very frustrating.

@nickbarnwell
Copy link

That's not a bug, that's a deleted user.

@ankitshah811
Copy link
Member Author

@nickbarnwell How is the user deleted? Users can't delete themselves rn (I know that's poor practice, but I removed that functionality for time being), and we didn't delete any users after 25 September, did we?

/ can we make it so that a deleted user doesn't occupy the spot of someone who could come off the waiting list?

(also apologies if reopening issue here was not the best practice. Not sure how to best approach this.)

@ankitshah811 ankitshah811 reopened this Sep 26, 2014
@nickbarnwell
Copy link

They could have deleted themselves by manually calling the route. Not out of the question for a technical user. As for the not taking up a spot, you need to think through what we should actually do with deleted users, how to handle disabling v. permanent deletion of an account, etc.

On another note, please stop posting screenshots with PII to the issue tracker! Your future legal department is crying right now!

@ankitshah811
Copy link
Member Author

LOL I often forget this is all public. Thanks for the reminder.

How I think this should work —

  1. User's past tea time attendances should still be marked as [Deleted User] with attendance_status as whatever it was beforehand.
  2. User's future tea time attendances should be marked as [Deleted User] with attendance_status = flake

Would we be able to commonly identify a Deleted User as being the same one as another Deleted User? For example, can we pinpoint whether or not Benny's two tea times have the same person who deleted their account marked as attending? (i.e. DeletedUser42 as opposed to the universal DeletedUser)

Still baffles me how somebody deleted their account, as there are 2 instances of future tea times with a deleted user marked as attending / 1 future tea where deleted is marked as flake. Is it a URL they'd go to? Or would they need to use dev tools?

@ankitshah811 ankitshah811 reopened this Sep 26, 2014
@ankitshah811 ankitshah811 changed the title Users can have no email address Handling deleted user attendance data Sep 26, 2014
nickbarnwell pushed a commit that referenced this issue Jun 6, 2015
nickbarnwell pushed a commit that referenced this issue Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants