Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email copy #262

Merged
merged 4 commits into from
Oct 8, 2014
Merged

Email copy #262

merged 4 commits into from
Oct 8, 2014

Conversation

ankitshah811
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) when pulling 1822eb4 on email-copy into 1496435 on master.

@ankitshah811
Copy link
Member Author

@nickbarnwell The only test here that failed was a weak one — checking to see that tea_time.friendly_time was in the subject line of host_confirmation email. I decided to change the formatting, but it doesn't break function. Can I merge and push?

@nickbarnwell
Copy link

Just change or remove the test.
On Oct 8, 2014 3:17 PM, "ankitshah811" notifications@github.com wrote:

@nickbarnwell https://github.com/nickbarnwell The only test here that
failed was a weak one — checking to see that tea_time.friendly_time was
in the subject line of host_confirmation email. I decided to change the
formatting, but it doesn't break function. Can I merge and push?


Reply to this email directly or view it on GitHub
#262 (comment)
.

ankitshah811 added a commit that referenced this pull request Oct 8, 2014
@ankitshah811 ankitshah811 merged commit 453dd54 into master Oct 8, 2014
@ankitshah811 ankitshah811 deleted the email-copy branch October 8, 2014 23:06
@nickbarnwell
Copy link

👍

From: ankitshah811
Sent: ‎Wednesday‎, ‎8‎ ‎October‎ ‎2014 ‎16‎:‎06
To: TeaWithStrangers/tws-on-rails
Cc: Nick Barnwell

Merged #262.


Reply to this email directly or view it on GitHub.

ankitshah811 added a commit that referenced this pull request Jun 6, 2015
ankitshah811 added a commit that referenced this pull request Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants