Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vue script setup SFCs #7

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Support Vue script setup SFCs #7

merged 3 commits into from
Jan 28, 2022

Conversation

setn
Copy link
Contributor

@setn setn commented Jan 26, 2022

I am doing some Vue 3 work and I need a newer version of the vue rules to support the defineProps and defineEmits compiler macros. I have not however been able to test this change because when I link to my local repo with this branch eslint fails with Error: Failed to load config "@teachiq" to extend from. nor have I tested this change with any other code base than mine 馃槵

How do you test changes to this repo?

@setn setn requested a review from Edugolr January 26, 2022 14:50
@setn
Copy link
Contributor Author

setn commented Jan 27, 2022

@Edugolr I have made a few tweaks now to get this to work flawlessly with teachiq-ab. I had to remove vue/eslint-config-standard because there is no version of that that supports version 8 of eslin-plugin-vue. vue/eslint-config-standard is really tiny and has not been updated in 2 years so I would argue that as a whole we are better off without it unless it does something I have not been able to discover.

@Edugolr
Copy link
Contributor

Edugolr commented Jan 27, 2022

@Edugolr I have made a few tweaks now to get this to work flawlessly with teachiq-ab. I had to remove vue/eslint-config-standard because there is no version of that that supports version 8 of eslin-plugin-vue. vue/eslint-config-standard is really tiny and has not been updated in 2 years so I would argue that as a whole we are better off without it unless it does something I have not been able to discover.

I think this looks great!
Yeah the vue/eslint-config-standard didn't seem to be used, or was it depended on from some other part ? Either way, great that it was removable now, especially since it doesn't seem to be maintained.

Have you confirmed that the "@vue/eslint-config-typescript": "^10.0.0" works ? I think I recall having some issue trying to go higher than 8 before.

@setn
Copy link
Contributor Author

setn commented Jan 27, 2022

Have you confirmed that the "@vue/eslint-config-typescript": "^10.0.0" works ? I think I recall having some issue trying to go higher than 8 before.

It runs fine with teachiq-ab and that version has "eslint-plugin-vue": "^8.0.1" as a peer dependency so seems like the best version for what we have now.

@setn setn merged commit c4a82b9 into master Jan 28, 2022
@setn setn deleted the support-script-setup-sfc branch January 28, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants