Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crafters high performace impact 1.20.1 #394

Closed
Sudoasroot opened this issue Jul 30, 2023 · 2 comments · Fixed by #418
Closed

[BUG] Crafters high performace impact 1.20.1 #394

Sudoasroot opened this issue Jul 30, 2023 · 2 comments · Fixed by #418
Assignees
Labels
MC-1.20.1 P-0-High High priority, crash/breaking. Type-Bug There is a problem.

Comments

@Sudoasroot
Copy link

The bug
Having ~5 active Crafters running on the Server is heavily dragging it's TPS from ~20 to ~9

To Reproduce
Steps to reproduce the behavior:

  1. Place around 5 EnderIO Crafters in your Server world
  2. get them busy with a slight crafting load
  3. Run the Spark Profiler & Check the tick impact in the Tree

Expected behavior
The Crafter is of course expected to put a calculating load on the Server, but just not that much.

Screenshots
2 (2)
1

Version information:

  • Server: Linux Debian 9
  • Java version java version 17.0.6 64-bit
  • Minecraft version 1.20.1 - All the Mods 9 V.0.0.45
  • EnderCore version - None
  • Version EnderIO-6.0.7-alpha
  • Forge Version forge-1.20.1-47.1.3
@Sudoasroot Sudoasroot added Status-Triage A Triage Member should take a look at this Type-Bug There is a problem. labels Jul 30, 2023
@Rover656 Rover656 added MC-1.20.1 P-0-High High priority, crash/breaking. labels Jul 30, 2023
@Rover656
Copy link
Member

Thanks for your report, we will investigate this :)

@jollycar
Copy link
Contributor

jollycar commented Aug 2, 2023

The reason is probably the getLevel().getRecipeManager() in CrafterBlockEntity. This is done every tick. Other enderIO BlockEntities use recipe caches. I might try to refactor this and create a pull request, if you want.

@tyler489 tyler489 removed the Status-Triage A Triage Member should take a look at this label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 P-0-High High priority, crash/breaking. Type-Bug There is a problem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants