Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve crafter performanc #418

Merged
merged 3 commits into from Aug 4, 2023
Merged

improve crafter performanc #418

merged 3 commits into from Aug 4, 2023

Conversation

agnor99
Copy link
Contributor

@agnor99 agnor99 commented Aug 3, 2023 •
edited

Description

prevent recipe lookup every tick, after recipe finish it checks if the recipe is still valid (datapack reload etc.)

Closes #394

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

jollycar
jollycar reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@jollycar jollycar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to fix stack overflow error introduced in this branch

@Rover656 Rover656 merged commit f5ca4b2 into dev/1.20.1 Aug 4, 2023
3 checks passed
@Rover656 Rover656 deleted the fix/crafter_lag branch August 4, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jollycar jollycar jollycar left review comments

@Rover656 Rover656 Rover656 left review comments

@ferriarnus ferriarnus ferriarnus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Crafters high performace impact 1.20.1
4 participants
@agnor99 @jollycar @Rover656 @ferriarnus