Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiblock energy storage charging when reaching int.max #330

Merged
merged 1 commit into from Aug 5, 2023

Conversation

GotoFinal
Copy link
Contributor

@GotoFinal GotoFinal commented Jul 22, 2023

Description

Small fix to make multiblock capacitor accept more than int.max energy.

Also small optimisation to code extracting/receiving energy - but I believe this code overall could use more love... But I don't personally use enderio much for it and it requires bigger work so not motivated myself...
Currently every operation on multiblock copies the data from graph, shuffles it, and iterates over all elements (well now not always all), this will make these multiblock structures to cause quite high load, especially when they are big and empty/full, as each operation will repeat every tick doing nothing.

Closes #302

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added this to the "More Features" (v6.1) milestone Jul 24, 2023
@GotoFinal
Copy link
Contributor Author

I'm a bit confused by the milestones now, the issue this PR fixes is in 6.0, yet the PR is in 6.1? @Rover656

@Rover656
Copy link
Member

Milestones are currently being shifted around, this one should probably continue to target 6.0, I'll fix this :) Cheers

@Rover656 Rover656 changed the base branch from dev/1.20.1 to release/1.20.1 July 25, 2023 13:34
@Rover656 Rover656 changed the base branch from release/1.20.1 to dev/1.20.1 July 30, 2023 18:21
@Rover656
Copy link
Member

Rover656 commented Aug 2, 2023

Just so you know; I'm not forgetting about this one either, I'd just like to let agnor decide if these changes make sense, as I didn't have any part in how this system works :)

Copy link
Contributor

@agnor99 agnor99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, I wanted to do some performance improvements for cap banks, but this is a good fix for the time being, thanks a lot

@agnor99 agnor99 merged commit 0acdfcf into Team-EnderIO:dev/1.20.1 Aug 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Capacitor Bank energy limit
3 participants