Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Soul Engine #357

Merged
merged 32 commits into from Aug 20, 2023
Merged

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Jul 26, 2023

Description

Add a new take on the zombie/franken/ender/lava generators. These now all are the same machine, but produce based on which mob soul is bound to it.

Closes #139 , Closes #140 , Closes #197

Todo

  • Better name?
  • Models
  • Gui's
  • Add all souls
  • Rewrite the soulbinder recipe to use the soul data

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@ferriarnus ferriarnus marked this pull request as ready for review August 1, 2023 11:03
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JEI Soul Binding entry missing, it knows there is a recipe but its blank.
Generator working all good though.
Would suggest aligning JEI info for the generator left so larger mob names fit, and fixing the JEI title from "Alloy Smelting"

Nice work, thanks Ferri!

@Rover656 Rover656 self-requested a review August 19, 2023 16:35
@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 labels Aug 19, 2023
@Rover656 Rover656 changed the title Add Mob generator Add the Soul Engine Aug 19, 2023
Rover656
Rover656 previously approved these changes Aug 19, 2023
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, thanks a lot Ferri!!

@Rover656 Rover656 merged commit 5ec6805 into Team-EnderIO:dev/1.20.1 Aug 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JEI Binding Recipe renders wrong souls Lava Heat Exchanger Zombie Generator
2 participants