Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enchanter shift-click and Exp cost #368

Merged
merged 4 commits into from Jul 27, 2023
Merged

Fix Enchanter shift-click and Exp cost #368

merged 4 commits into from Jul 27, 2023

Conversation

ferriarnus
Copy link
Member

Description

Fix Enchanter shift-click and Exp cost

Closes: #352 Closes: #359

Todo

  • Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Rover656
Rover656 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, cheers again Ferri!!

@Rover656 Rover656 merged commit 6d7e29e into Team-EnderIO:dev/1.20.1 Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Enchanter requires more levels than it should [BUG] Enchanter: No xp consumed on shift-click
2 participants
@ferriarnus @Rover656