Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Machine Item Consumption #412

Merged
merged 2 commits into from Aug 2, 2023

Conversation

ferriarnus
Copy link
Member

Description

Fixes Machine Item consumption, which leads to infinite recipe reloading when the output is full trying to find a recipe that could be placed.

Closes #409

Todo

  • Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that all machines work with this change? This could be a remnant from the swap away from consuming first, but all I know is this condition was added for a reason. If you can test all the machines and confirm they work, then feel free to merge this. Thanks a lot!

@ferriarnus
Copy link
Member Author

I'm double check, but this does seem to be a leftover. What this check does is look if the item can be placed as an output, and if not, it will restart the crafting task. However now we can always start the task, but we just need to wait to place the outputs until there's room. For other machines, this doesn't matter, as the recipe will always have the same outputs. In that case the task never starts until room is made.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, I'm happy with that explanation. Thank you!

@Rover656 Rover656 merged commit 01ea4c4 into Team-EnderIO:dev/1.20.1 Aug 2, 2023
3 checks passed
@ferriarnus ferriarnus deleted the placelogicfix branch August 16, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SAG Mill does not stop producing
2 participants