New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor changes #456
Merged
Merged
Anchor changes #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/machines/java/com/enderio/machines/common/block/TravelAnchorBlock.java
Show resolved
Hide resolved
src/main/java/com/enderio/base/common/travel/TravelSavedData.java
Outdated
Show resolved
Hide resolved
ferriarnus
commented
Aug 12, 2023
src/machines/java/com/enderio/machines/common/block/TravelAnchorBlock.java
Show resolved
Hide resolved
1 task
Rover656
added
Type-Bug
There is a problem.
MC-1.20.1
P-1-Medium
Medium priority. Potentially deleting items or breaking functionality.
labels
Aug 18, 2023
Rover656
requested changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is almost there, just need to fix the block item rendering (see discord)
make render based on player pos scale blocks properly
Rover656
approved these changes
Aug 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks a lot to both Ferri and chonky :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MC-1.20.1
P-1-Medium
Medium priority. Potentially deleting items or breaking functionality.
Type-Bug
There is a problem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resets the client collection of targets when changing a dimension
Fix syncing of the name to the server/client
Closes #454
Todo
Checklist: