Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor changes #456

Merged
merged 9 commits into from Aug 19, 2023
Merged

Anchor changes #456

merged 9 commits into from Aug 19, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Aug 12, 2023

Description

Resets the client collection of targets when changing a dimension
Fix syncing of the name to the server/client

Closes #454

Todo

  • Verify this is all that is needed

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@ferriarnus ferriarnus marked this pull request as draft August 12, 2023 20:49
@ferriarnus ferriarnus marked this pull request as ready for review August 14, 2023 22:57
@Rover656 Rover656 added Type-Bug There is a problem. MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. labels Aug 18, 2023
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is almost there, just need to fix the block item rendering (see discord)

make render based on player pos
scale blocks properly
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks a lot to both Ferri and chonky :)

@Rover656 Rover656 merged commit d1af5b0 into Team-EnderIO:dev/1.20.1 Aug 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. Type-Bug There is a problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travel Anchors showing interdimensionally
4 participants