Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active textures of Machines #466

Merged
merged 3 commits into from Aug 16, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Aug 16, 2023

Description

Fix active textures of Machines.
Add breaking particles for machines. In the future, it might be worth looking at a custom model loader, but right now I don't think so as we will get new models.

Closes #451

Todo

  • active texture for the primitive alloy smelter

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I'm not a fan of having a dummy texture for the enchanter - could we hardcode the enchanter case for the minute and then this can be removed again once I redesign the model loader.
  2. Add the old simple alloy smelter on face for the primitive as a temporary :)

Thanks!

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Ferri!

@Rover656 Rover656 merged commit 16c7252 into Team-EnderIO:dev/1.20.1 Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] No Machine Break Particles
2 participants