Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slot on Shift Click #467

Merged
merged 2 commits into from Aug 16, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Aug 16, 2023

Description

Shift Clicking an item calls the slot.setChanged method, however, it does not call onContentChanged as it should as well. This PR solves that by using slot.set instead of directly changing the itemstack.

Closes #445

Todo

  • Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will trust that this works, but looks like it makes sense. Cheers!

@Rover656 Rover656 merged commit 38a1f32 into Team-EnderIO:dev/1.20.1 Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Shift clicking stack into machine doesn't start recipe
2 participants