Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize shape calls #476

Merged
merged 1 commit into from Oct 13, 2023
Merged

Conversation

ferriarnus
Copy link
Member

Description

Some small changes to the conduit shape code. Mainly only optimizing the shape at the end, not after every step.
Secondly, remove some loops that don't happen because it's only for a single conduit type

Closes #(issue)

Todo

  • Verify nothing broke with the removal of the loops.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 requested a review from agnor99 August 19, 2023 16:35
@Rover656 Rover656 added Area-Backend Backend work not usually visible to players. MC-1.20.1 Area-Conduits Everything involving conduits labels Sep 5, 2023
@Rover656
Copy link
Member

Performed a rebase to handle the ConduitShape conflict.

@Rover656 Rover656 merged commit d0253d2 into Team-EnderIO:dev/1.20.1 Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Backend Backend work not usually visible to players. Area-Conduits Everything involving conduits MC-1.20.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants