Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Machine active tooltip #479

Merged
merged 19 commits into from Nov 26, 2023
Merged

Add Machine active tooltip #479

merged 19 commits into from Nov 26, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Aug 20, 2023 •
edited

Description

This PR adds more info to the machines, making it easier for users to find out what is wrong.

  • Add Machine active tooltip.
  • Add Bind soul tooltip on items.

Closes #472

Todo

  • Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@mystchonky mystchonky mentioned this pull request Aug 21, 2023
Merged
5 tasks
@ferriarnus ferriarnus marked this pull request as draft August 23, 2023 18:28
@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 labels Sep 5, 2023
@Rover656
Copy link
Member

What's needing done before this leaves draft?

@ferriarnus ferriarnus marked this pull request as ready for review November 11, 2023 15:22
Rover656
Rover656 requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise this looks fantastic - Unsure if we're worried about the flicker between ready and active for example when an alloy smelter finishes a task and picks another, but I'm super happy with how this is working and if this is going to change, I'd suggest doing so in a future PR.

src/machines/java/com/enderio/machines/client/gui/widget/ActiveWidget.java Outdated Show resolved Hide resolved
src/machines/java/com/enderio/machines/client/gui/widget/CapacitorEnergyWidget.java Show resolved Hide resolved
src/machines/java/com/enderio/machines/common/blockentity/MachineStateType.java Show resolved Hide resolved
src/machines/java/com/enderio/machines/common/blockentity/XPVacuumBlockEntity.java Show resolved Hide resolved
Rover656
Rover656 approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thanks a lot!

@Rover656 Rover656 merged commit b7f9850 into Team-EnderIO:dev/1.20.1 Nov 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Crash Alloy Smelter, Stirling Generator.
3 participants
@ferriarnus @Rover656 @mystchonky