Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Health Work #490

Merged
merged 14 commits into from Sep 22, 2023
Merged

Code Health Work #490

merged 14 commits into from Sep 22, 2023

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Aug 21, 2023

Description

Just an absolute wall of code health changes. Setting up checkstyle to try and keep stuff consistent and setting up a github action that will comment recommendations on PRs.

Todo

  • Work this out later :)

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 added the Area-Backend Backend work not usually visible to players. label Aug 21, 2023
@Rover656
Copy link
Member Author

Going to merge this - it doesn't change code other than fixing violated rules. Rules can be softened or hardened at a later date, and the automatic PR reviewer is functional.

@Rover656 Rover656 merged commit 7a2bbde into dev/1.20.1 Sep 22, 2023
4 checks passed
@Rover656 Rover656 deleted the chore/code-health branch September 22, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Backend Backend work not usually visible to players.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant