Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency between recipes #506

Merged
merged 6 commits into from Sep 7, 2023
Merged

Improve consistency between recipes #506

merged 6 commits into from Sep 7, 2023

Conversation

rlnt
Copy link
Contributor

@rlnt rlnt commented Sep 6, 2023

Description

I split changes to the datagen code and the datagen itself to different commits for easier readability.

  • enabled option to insert a final newline in editorconfig since all files are already formatted like that
  • made the sag mill recipe use proper formatting according to other recipes (camel case and snake case)
  • renamed recipe collection classes to match the naming of other recipe providers
  • changed the enchanter recipe and recipe provider to make use of the counted ingredient

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation. (is there documentation? 馃槄)
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks perfectly reasonable to me, thanks a lot for contributing these changes; and thanks for your work on kubejs enderio compat too!!

@Rover656
Copy link
Member

Rover656 commented Sep 7, 2023

Build passed, merging.

@Rover656 Rover656 merged commit e48f02f into Team-EnderIO:dev/1.20.1 Sep 7, 2023
3 checks passed
@rlnt rlnt deleted the consistency branch September 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants