Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds overlay on top of Ghost and Preview Slots #549

Merged
merged 4 commits into from Nov 11, 2023

Conversation

mystchonky
Copy link
Contributor

Description

Adds overlay on top of slots that make them looks faded indicated that they arent proper slots in which player can
put and extract normal items
Also adds a wrapper MachineScreen class so that functionality can be shared across all machines.

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor tweak, but I'm happy with how this looks - thanks a lot chonky!

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 Area-Rendering Rendering code, might be shaders specific or general. labels Nov 11, 2023
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks a lot chonky!

@Rover656 Rover656 merged commit c39cbc3 into Team-EnderIO:dev/1.20.1 Nov 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Rendering code, might be shaders specific or general. MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants