Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inter-mod wrench compatibility #566

Merged
merged 3 commits into from Nov 23, 2023
Merged

Add inter-mod wrench compatibility #566

merged 3 commits into from Nov 23, 2023

Conversation

DoctorNefario
Copy link
Contributor

Description

Uses the (existing) forge:tools/wrench tag to let wrenches from other mods call onWrenched.

Resolves #539

Todo

  • Move/rename EnderIOWrenchCompat?
  • Test more mod wrenches
    • Already confirmed that AE2, Mekanism, and RFTools are working

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@agnor99 agnor99 merged commit f754ae8 into Team-EnderIO:dev/1.20.1 Nov 23, 2023
4 checks passed
@DoctorNefario DoctorNefario deleted the feature/wrench-compat branch November 24, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnor99 agnor99 agnor99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inter-mod wrench compatibility?
2 participants
@DoctorNefario @agnor99